|
From: | Peter Maydell |
Subject: | Re: [Qemu-devel] [PATCH v3] PIIX3: reset the VM when the Reset Control Register's RCPU bit gets set |
Date: | Fri, 25 Jan 2013 17:23:51 +0000 |
On 25 January 2013 17:20, Laszlo Ersek <address@hidden> wrote: > The subscript operator [] is used here in the type name of a compound > literal which is probably not what the script intends to catch. > > 1945 # check for spacing round square brackets; allowed: > 1946 # 1. with a type on the left -- int [] a; > > The code in question was copied from "docs/migration.txt" and seems to > match existing practice: > > git grep -E '(VMStateField|VMStateSubsection) \[]' \ > | wc -l > > 139 On the other hand the usage without the space is in the majority: git grep -E '(VMStateField|VMStateSubsection)\[]' | wc -l 218 -- PMM
[Prev in Thread] | Current Thread | [Next in Thread] |