[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/8] fw_cfg: Replace debug prints by tracepoints
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 1/8] fw_cfg: Replace debug prints by tracepoints |
Date: |
Fri, 25 Jan 2013 10:40:38 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Jan 24, 2013 at 11:46:28AM +0100, Peter Lieven wrote:
>
> Am 24.01.2013 um 11:41 schrieb Andreas Färber <address@hidden>:
>
> > Am 24.01.2013 11:32, schrieb Markus Armbruster:
> >> Peter Lieven <address@hidden> writes:
> >>
> >>> Latest git doesn't compile with this patch:
> >>>
> >>> hw/fw_cfg.c: In function 'fw_cfg_write':
> >>> hw/fw_cfg.c:207:5: error: implicit declaration of function
> >>> trace_fw_cfg_write' [-Werror=implicit-function-declaration]
> >>> hw/fw_cfg.c:207:5: error: nested extern declaration of
> >>> trace_fw_cfg_write' [-Werror=nested-externs]
> >>> hw/fw_cfg.c: In function 'fw_cfg_select':
> >>> hw/fw_cfg.c:232:5: error: implicit declaration of function
> >>> trace_fw_cfg_select' [-Werror=implicit-function-declaration]
> >>> hw/fw_cfg.c:232:5: error: nested extern declaration of
> >>> trace_fw_cfg_select' [-Werror=nested-externs]
> >>> hw/fw_cfg.c: In function 'fw_cfg_read':
> >>> hw/fw_cfg.c:247:5: error: implicit declaration of function
> >>> trace_fw_cfg_read' [-Werror=implicit-function-declaration]
> >>> hw/fw_cfg.c:247:5: error: nested extern declaration of
> >>> trace_fw_cfg_read' [-Werror=nested-externs]
> >>> hw/fw_cfg.c: In function 'fw_cfg_add_file':
> >>> hw/fw_cfg.c:460:13: error: implicit declaration of function
> >>> trace_fw_cfg_add_file_dupe' [-Werror=implicit-function-declaration]
> >>> hw/fw_cfg.c:460:13: error: nested extern declaration of
> >>> trace_fw_cfg_add_file_dupe' [-Werror=nested-externs]
> >>> hw/fw_cfg.c:467:5: error: implicit declaration of function
> >>> trace_fw_cfg_add_file' [-Werror=implicit-function-declaration]
> >>> hw/fw_cfg.c:467:5: error: nested extern declaration of
> >>> trace_fw_cfg_add_file' [-Werror=nested-externs]
> >>> cc1: all warnings being treated as errors
> >>> make: *** [hw/fw_cfg.o] Error 1
> >>
> >> Compiles fine for me.
> >>
> >> What happens if you blow away your build tree and start over?
> >>
> >> In my experience, rebuilding of trace-related stuff is rather fragile...
> >
> > There were some recent changes ... there's probably a stale trace.h and
> > trace.c in the build directory.
>
> removing trace.c and trace.h is not enough, but a fresh clone of the
> repository works. are there any more such files?
If you hit other issues you can avoid them using a build directory:
$ mkdir build
$ cd build
$ path/to/qemu/configure ...
$ make
It places all generated files and build products into this directory.
Simply 'rm -rf build' to start from a clean slate.
Stefan
- [Qemu-devel] [PATCH 0/8] Fixes and cleanups around fw_cfg, Markus Armbruster, 2013/01/16
- [Qemu-devel] [PATCH 3/8] fw_cfg: New fw_cfg_add_string(), Markus Armbruster, 2013/01/16
- [Qemu-devel] [PATCH 4/8] pc: Fix unchecked strdup() by switching to fw_cfg_add_string(), Markus Armbruster, 2013/01/16
- [Qemu-devel] [PATCH 7/8] fw_cfg: Use void *, size_t instead of uint8_t *, uint32_t for blobs, Markus Armbruster, 2013/01/16
- [Qemu-devel] [PATCH 1/8] fw_cfg: Replace debug prints by tracepoints, Markus Armbruster, 2013/01/16
- Re: [Qemu-devel] [PATCH 1/8] fw_cfg: Replace debug prints by tracepoints, Peter Lieven, 2013/01/24
- Re: [Qemu-devel] [PATCH 1/8] fw_cfg: Replace debug prints by tracepoints, Markus Armbruster, 2013/01/24
[Qemu-devel] [PATCH 8/8] vl: Use size_t for sizes in get_boot_devices_list(), Markus Armbruster, 2013/01/16
[Qemu-devel] [PATCH 2/8] fw_cfg: Dumb down fw_cfg_add_*() not to return success / failure, Markus Armbruster, 2013/01/16
[Qemu-devel] [PATCH 5/8] sun4: Fix unchecked strdup() by switching to fw_cfg_add_string(), Markus Armbruster, 2013/01/16
[Qemu-devel] [PATCH 6/8] pc: Clean up bochs_bios_init()'s (non-)use of sizeof, Markus Armbruster, 2013/01/16
Re: [Qemu-devel] [PATCH 0/8] Fixes and cleanups around fw_cfg, Gleb Natapov, 2013/01/17