[Qemu-devel] [A cry for sanity]: make_device_config.sh: Fix target path in generated dependency file

[Michael Tokarev]

Guys, it isn't sane anymore.  It if FAR from being funny.

Ping^7.. if i counted correctly...

03.12.2012 23:31, mdroth wrote:
> On Sat, Oct 27, 2012 at 12:32:28PM +0400, Michael Tokarev wrote:
> > Ping?
>
> Ping.
>
> Fix still applicable for 1.3, also looking to pull it in for 1.2.2.
>
> > /mjt
> >
> > On 18.09.2012 18:32, Andreas Färber wrote:
> > > Am 18.09.2012 14:29, schrieb Michael Tokarev:
> > > > Has it been applied to anything?  I don't think so.
> > > > Is it still needed?
> > >
> > > Not in qemu.git yet, still applicable AFAICT. CC'ing Paolo.
> > >
> > > /-F
> > >
> > > > Thanks,
> > > >
> > > > /mjt
> > > >
> > > > On 07.06.2012 20:23, Andreas Färber wrote:
> > > > > config-devices.mak.d is included from Makefile.target, i.e. from inside
> > > > > the *-softmmu/ directory. It included the directory path, so never
> > > > > applied to the actual config-devices.mak. Symptoms were spurious
> > > > > dependency issues with default-configs/pci.mak.
> > > > >
> > > > > Fix by using `basename` to strip the directory path.
> > > > >
> > > > > Reported-by: Gerhard Wiesinger <address@hidden>
> > > > > Signed-off-by: Andreas Färber <address@hidden>
> > > > > ---
> > > > >   Seems I forgot to send this out before 1.1...
> > > > >
> > > > >   scripts/make_device_config.sh |    2 +-
> > > > >   1 files changed, 1 insertions(+), 1 deletions(-)
> > > > >
> > > > > diff --git a/scripts/make_device_config.sh b/scripts/make_device_config.sh
> > > > > index 5d14885..0778fe2 100644
> > > > > --- a/scripts/make_device_config.sh
> > > > > +++ b/scripts/make_device_config.sh
> > > > > @@ -25,4 +25,4 @@ done
> > > > >   process_includes $src > $dest
> > > > >
> > > > >   cat $src $all_includes | grep -v '^include' > $dest
> > > > > -echo "$1: $all_includes" > $dep
> > > > > +echo "`basename $1`: $all_includes" > $dep