|
| From: | Scott Wood |
| Subject: | Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/5] target-ppc: Synchronize FPU state with KVM |
| Date: | Wed, 23 Jan 2013 16:12:08 -0600 |
On 01/23/2013 04:05:56 PM, David Gibson wrote:
On Wed, Jan 23, 2013 at 11:56:04AM -0600, Scott Wood wrote: > I don't see where you check a capability, so users of pre-one-reg > KVM now get (at least) 33 warning messages every time context gets > synchronized? Given that a bunch of important state is missing from that synchronization, I think a slew of warnings is entirely appropriate. There are no per-register capabilities so there's nothing we can check here.
"Important" is debatable. It should be obvious enough for debugging to see that the FP state is all zeroes and conclude that something's missing. Maybe print one warning on the first failure. As for savevm, those old kernels won't support migration anyway on PPC, right?
-Scott
| [Prev in Thread] | Current Thread | [Next in Thread] |