[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-1.4 02/12] target-i386: Don't set any KVM fl
From: |
Marcelo Tosatti |
Subject: |
Re: [Qemu-devel] [PATCH for-1.4 02/12] target-i386: Don't set any KVM flag by default if KVM is disabled |
Date: |
Mon, 21 Jan 2013 23:44:06 -0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Jan 17, 2013 at 06:59:28PM -0200, Eduardo Habkost wrote:
> This is a cleanup that tries to solve two small issues:
>
> - We don't need a separate kvm_pv_eoi_features variable just to keep a
> constant calculated at compile-time, and this style would require
> adding a separate variable (that's declared twice because of the
> CONFIG_KVM ifdef) for each feature that's going to be enabled/disable
> by machine-type compat code.
> - The pc-1.3 code is setting the kvm_pv_eoi flag on cpuid_kvm_features
> even when KVM is disabled at runtime. This small incosistency in
> the cpuid_kvm_features field isn't a problem today because
> cpuid_kvm_features is ignored by the TCG code, but it may cause
> unexpected problems later when refactoring the CPUID handling code.
>
> This patch eliminates the kvm_pv_eoi_features variable and simply uses
> kvm_enabled() inside the enable_kvm_pv_eoi() compat function, so it
> enables kvm_pv_eoi only if KVM is enabled. I believe this makes the
> behavior of enable_kvm_pv_eoi() clearer and easier to understand.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Marcelo Tosatti <address@hidden>
- [Qemu-devel] [PATCH for-1.4 00/12] target-i386: Fix APIC-ID-based topology (v4), Eduardo Habkost, 2013/01/17
- [Qemu-devel] [PATCH for-1.4 10/12] tests: Support target-specific unit tests, Eduardo Habkost, 2013/01/17
- [Qemu-devel] [PATCH for-1.4 02/12] target-i386: Don't set any KVM flag by default if KVM is disabled, Eduardo Habkost, 2013/01/17
- [Qemu-devel] [PATCH for-1.4 06/12] fw_cfg: Remove FW_CFG_MAX_CPUS from fw_cfg_init(), Eduardo Habkost, 2013/01/17
- [Qemu-devel] [PATCH for-1.4 12/12] pc: Generate APIC IDs according to CPU topology, Eduardo Habkost, 2013/01/17
- [Qemu-devel] [PATCH for-1.4 03/12] pc: Reverse pc_init_pci() compatibility logic, Eduardo Habkost, 2013/01/17
- [Qemu-devel] [PATCH for-1.4 05/12] target-i386: kvm: Set vcpu_id to APIC ID instead of CPU index, Eduardo Habkost, 2013/01/17
- [Qemu-devel] [PATCH for-1.4 01/12] kvm: Add fake KVM_FEATURE_CLOCKSOURCE_STABLE_BIT for builds withou KVM, Eduardo Habkost, 2013/01/17