[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] checkpatch: add a little script to run checkpat
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [PATCH] checkpatch: add a little script to run checkpatch against a git refspec |
Date: |
Mon, 21 Jan 2013 16:04:41 -0600 |
User-agent: |
Notmuch/0.13.2+93~ged93d79 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
Peter Maydell <address@hidden> writes:
> On 21 January 2013 19:21, Anthony Liguori <address@hidden> wrote:
>> Peter Maydell <address@hidden> writes:
>>> On 21 January 2013 16:48, Anthony Liguori <address@hidden> wrote:
>>>> This makes it easier to use checkpatch with a git hook or via patches.
>
>>> Any chance of a note in the comments about how to actually hook
>>> it up to a git hook or patches?
>
>> That was sort of a theoritical statement. Normally you would use a
>> pre-hook to do this and just use a git diff. I assume you can use a
>> post-receive hook with this script but I'm not sure that's relevant to
>> anyone other than me.
>
> Well, the implication of putting the script into the qemu git repo
> is that it's a useful tool for people other than you. So it should
> be possible to add a brief description of how it's useful. If it's
> not useful for anybody else then you should keep it in your own
> local config :-)
$ scripts/check-patches.sh origin/master..HEAD
On your topic branch before submission. I don't use commit hooks
because that would be annoying.
It's a darn simple script though so unless you don't know what a refspec
is it shouldn't need much explanation.
Regards,
Anthony Liguori
>
> -- PMM