[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/5] target-i386: print deprecated warning if xl
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 1/5] target-i386: print deprecated warning if xlevel < 0x80000000 |
Date: |
Mon, 21 Jan 2013 15:56:52 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2 |
Am 21.01.2013 15:06, schrieb Igor Mammedov:
> Signed-off-by: Igor Mammedov <address@hidden>
> Reviewed-by: Eduardo Habkost <address@hidden>
> ---
> Amend warning message as suggested by Andreas s/depricated/removed/
Thanks, applied to qom-cpu queue:
https://github.com/afaerber/qemu-cpu/commits/qom-cpu
Andreas
> ---
> target-i386/cpu.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index d1a14d5..f0f3df1 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1394,6 +1394,8 @@ static int cpu_x86_parse_featurestr(x86_def_t
> *x86_cpu_def, char *features)
> goto error;
> }
> if (numvalue < 0x80000000) {
> + fprintf(stderr, "xlevel value shall always be >=
> 0x80000000"
> + ", fixup will be removed in future versions\n");
> numvalue += 0x80000000;
> }
> x86_cpu_def->xlevel = numvalue;
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH qom-cpu 0/5 v2] x86 CPU cleanup, part 4, Igor Mammedov, 2013/01/21
- [Qemu-devel] [PATCH 1/5] target-i386: print deprecated warning if xlevel < 0x80000000, Igor Mammedov, 2013/01/21
- Re: [Qemu-devel] [PATCH 1/5] target-i386: print deprecated warning if xlevel < 0x80000000,
Andreas Färber <=
- [Qemu-devel] [PATCH 4/5] target-i386: set custom features/properties without intermediate x86_def_t, Igor Mammedov, 2013/01/21
- [Qemu-devel] [PATCH 3/5] target-i386: remove vendor_override field from CPUX86State, Igor Mammedov, 2013/01/21
- [Qemu-devel] [PATCH 5/5] target-i386: remove setting tsc-frequency from x86_def_t, Igor Mammedov, 2013/01/21
- [Qemu-devel] [PATCH 2/5] target-i386: replace uint32_t vendor fields by vendor string in x86_def_t, Igor Mammedov, 2013/01/21
- Re: [Qemu-devel] [PATCH qom-cpu 0/5 v2] x86 CPU cleanup, part 4, Igor Mammedov, 2013/01/21
- Re: [Qemu-devel] [PATCH qom-cpu 0/5 v2] x86 CPU cleanup, part 4, Andreas Färber, 2013/01/26