Re: [Qemu-devel] [PATCH 1/5] target-i386: print deprecated warning if xlevel < 0x80000000

[Andreas Färber]

Am 17.01.2013 16:16, schrieb Igor Mammedov:
> Signed-off-by: Igor Mammedov <address@hidden>
> Reviewed-by: Eduardo Habkost <address@hidden>
> ---
>  target-i386/cpu.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 333745b..ce914da 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1399,6 +1399,8 @@ static int cpu_x86_parse_featurestr(x86_def_t 
> *x86_cpu_def, char *features)
>                      goto error;
>                  }
>                  if (numvalue < 0x80000000) {
> +                    fprintf(stderr, "xlevel value shall always be >= 
> 0x80000000"
> +                            ", fixup will be deprecated in future 
> versions\n");
>                      numvalue += 0x80000000;
>                  }
>                  x86_cpu_def->xlevel = numvalue;

This has been reviewed without objections so far, so I would apply it
for 1.4. Either way you should document this intent for users already:
http://wiki.qemu.org/ChangeLog/1.4

We had such discussions before, around removing cpudef support.

When do you plan to remove this, and being deprecated, shouldn't it
rather read "fixup will be removed in future versions"? ;)
If it fits within 80 chars I can edit it myself.

Cheers,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg