[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/3] Purge the silly GLib Basic Types
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH 0/3] Purge the silly GLib Basic Types |
Date: |
Sat, 19 Jan 2013 09:33:00 +0000 |
On Fri, Jan 18, 2013 at 4:17 PM, Anthony Liguori <address@hidden> wrote:
> Markus Armbruster <address@hidden> writes:
>
>> See PATCH 1/3 for rationale.
>>
>> Markus Armbruster (3):
>> Purge the silly GLib "Basic Types", except for gboolean
>> Purge GLib's gboolean, it's a trap for the unwary
>> checkpatch: Keep out the GLib silliness we just purged
>
> Changing QEMU code to work around checkpatch's failing is insane.
>
> When interacting with glib, use glib types. Not using those types just
> makes the code more difficult to understand.
While the types are indeed useless and even cause problems (gboolean),
I agree with Anthony. It's the same as using DWORD for Win32 APIs.
Maybe a smaller patch would make sense that minimizes the use of the
types to only GLib API calls and the variables nearby. Also if there
are real conversion problems with gboolean, those should be fixed.
>
> Regards,
>
> Anthony Liguori
>
>>
>> async.c | 12 +++++-------
>> coroutine-gthread.c | 8 ++++----
>> hw/9pfs/virtio-9p-coth.c | 2 +-
>> hw/fw_cfg.c | 6 +++---
>> hw/qdev-monitor.c | 2 +-
>> hw/qdev.c | 4 ++--
>> hw/xen_disk.c | 6 +++---
>> include/qom/object.h | 8 ++++----
>> main-loop.c | 2 +-
>> qapi/opts-visitor.c | 10 +++++-----
>> qapi/qmp-input-visitor.c | 4 ++--
>> qemu-img.c | 4 ++--
>> qga/channel-posix.c | 25 +++++++++++++------------
>> qga/channel-win32.c | 26 +++++++++++++-------------
>> qga/channel.h | 10 +++++-----
>> qga/commands-posix.c | 6 +++---
>> qga/commands.c | 2 +-
>> qga/guest-agent-command-state.c | 4 ++--
>> qga/guest-agent-core.h | 2 +-
>> qga/main.c | 16 ++++++++--------
>> qom/container.c | 2 +-
>> qom/object.c | 26 +++++++++++++-------------
>> qtest.c | 8 ++++----
>> scripts/checkpatch.pl | 29 +++++++++++++++++++++++++++++
>> target-alpha/cpu.c | 4 ++--
>> target-arm/cpu.c | 2 +-
>> target-arm/helper.c | 4 ++--
>> target-i386/cpu.c | 2 +-
>> target-m68k/helper.c | 4 ++--
>> target-openrisc/cpu.c | 4 ++--
>> target-ppc/translate_init.c | 12 ++++++------
>> tests/libqtest.c | 20 ++++++++++----------
>> tests/test-visitor-serialization.c | 12 ++++++------
>> trace/simple.c | 8 ++++----
>> vl.c | 6 +++---
>> 35 files changed, 165 insertions(+), 137 deletions(-)
>>
>> --
>> 1.7.11.7
- [Qemu-devel] [PATCH 0/3] Purge the silly GLib Basic Types, Markus Armbruster, 2013/01/18
- [Qemu-devel] [PATCH 3/3] checkpatch: Keep out the GLib silliness we just purged, Markus Armbruster, 2013/01/18
- [Qemu-devel] [PATCH 2/3] Purge GLib's gboolean, it's a trap for the unwary, Markus Armbruster, 2013/01/18
- [Qemu-devel] [PATCH 1/3] Purge the silly GLib "Basic Types", except for gboolean, Markus Armbruster, 2013/01/18
- Re: [Qemu-devel] [PATCH 0/3] Purge the silly GLib Basic Types, Anthony Liguori, 2013/01/18
- Re: [Qemu-devel] [PATCH 0/3] Purge the silly GLib Basic Types,
Blue Swirl <=