Re: [Qemu-devel] [PATCH 2/8] s390: Move IPL code into a separate device

[Andreas Färber]

Am 18.01.2013 19:12, schrieb Alexander Graf:
> diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
> new file mode 100644
> index 0000000..7cbbf99
> --- /dev/null
> +++ b/hw/s390x/ipl.c
[...]
> +static TypeInfo s390_ipl_info = {

This should probably be static const - my tree-wide cleanup didn't catch
s390-next obviously. Please follow-up with a fix to avoid this being copied.

Similar issue could exist for ppc-next, please check.

Andreas

> +    .class_init = s390_ipl_class_init,
> +    .parent = TYPE_SYS_BUS_DEVICE,
> +    .name  = "s390-ipl",
> +    .instance_size  = sizeof(S390IPLState),
> +};
> +
> +static void s390_ipl_register_types(void)
> +{
> +    type_register_static(&s390_ipl_info);
> +}
> +
> +type_init(s390_ipl_register_types)

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg