[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] win32-aio: use iov utility functions instead
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2] win32-aio: use iov utility functions instead of open-coding them |
Date: |
Fri, 18 Jan 2013 09:46:04 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Jan 17, 2013 at 05:51:05PM +0400, Michael Tokarev wrote:
> 17.01.2013 17:06, Stefan Hajnoczi wrote:
> >On Thu, Jan 17, 2013 at 02:44:41PM +0400, Michael Tokarev wrote:
> >>We have iov_from_buf() and iov_to_buf(), use them instead of
> >>open-coding these in block/win32-aio.c
> >
> >Please use qemu_iovec_from_buf() and qemu_iovec_to_buf() since we're
> >operating on a QEMUIOVector.
>
> I'd remove qemu_iovec_{from,to}_buf() completely at this point
> due to their trivialness and almost no gain in usage as polluting
> the namespace (having too many trivial utility functions isn't
> good). Right now these are only used in one place - in
> hw/dataplane/virtio-blk.c .
I like them because it makes the calling code nicer to read. It saves
us from pulling apart the QEMUIOVector struct.
But it's not a big deal to me. I can merge this version of the patch.
Stefan