[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/5] block: Fix error report for wrong file f
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/5] block: Fix error report for wrong file format |
Date: |
Thu, 17 Jan 2013 15:41:08 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 01/17/2013 03:25 PM, Stefan Weil wrote:
>>> * Use error code EMEDIUMTYPE instead of inventing a new one.
>>>
>> Alas, EMEDIUMTYPE is non-standard, and doesn't exist outside of Linux.
>> If you are providing fallbacks for half the platforms because you don't
>> want to use a standard errno value, then why not go all the way and use
>> a fallback for all platforms.
>>
>
> That's what I did in v1 of my patches: it used BDRV_WRONG_FORMAT.
>
> I didn't introduce a EFILEFORMAT because it looks like
> something used outside of the QEMU world (which is not true).
>
> If EFILEFORMAT (or any other new name) is preferred,
> I won't object. In this case, I can either send a new patch series,
> or whoever commits my patches can do a simple replace operation.
Fair enough; I won't hold up the patch series over a bikeshed choice of
error naming. So with that:
Series:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 3/5] block/vdi: Improve debug output for signature, (continued)
Re: [Qemu-devel] [PATCH v2 0/5] block: Fix error report for wrong file format, Eric Blake, 2013/01/17
Re: [Qemu-devel] [PATCH v2 0/5] block: Fix error report for wrong file format, Kevin Wolf, 2013/01/22