qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 08/11] qemu-log: Plug trivial memory leak in cpu


From: Blue Swirl
Subject: Re: [Qemu-devel] [PATCH 08/11] qemu-log: Plug trivial memory leak in cpu_set_log_filename()
Date: Thu, 17 Jan 2013 20:49:04 +0000

On Wed, Jan 16, 2013 at 4:06 PM, Markus Armbruster <address@hidden> wrote:
> Eric Blake <address@hidden> writes:
>
>> On 01/16/2013 07:36 AM, Markus Armbruster wrote:
>>> Signed-off-by: Markus Armbruster <address@hidden>
>>> ---
>>>  qemu-log.c | 13 +++++++++----
>>>  1 file changed, 9 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/qemu-log.c b/qemu-log.c
>>> index 64a1b88..1eadf1b 100644
>>> --- a/qemu-log.c
>>> +++ b/qemu-log.c
>>> @@ -21,10 +21,12 @@
>>>  #include "qemu/log.h"
>>>
>>>  #ifdef WIN32
>>> -static const char *logfilename = "qemu.log";
>>> +#define DEFAULT_LOGFILENAME = "qemu.log"
>>
>> Syntax error.
>
> How embarrassing.  Unfortunately, it compiles...  I'll respin.
>
>>> @@ -54,11 +56,13 @@ void qemu_log_mask(int mask, const char *fmt, ...)
>>>  /* enable or disable low levels log */
>>>  void qemu_set_log(int log_flags, bool use_own_buffers)
>>>  {
>>> +    const char *fname = logfilename ?: DEFAULT_LOGFILENAME;
>>
>> ?: is not C99, but a GNU extension.  What is our policy on using it?
>
> We got several dozen instancess of ?: spread over the tree.

I'd not add any more. It's a bad idea to add more dependencies to
specific tools than is necessary.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]