Re: [Qemu-devel] [PATCH] v6 revamp acpitable parsing and allow to specify complete (headerful) table

[Michael Tokarev]

Wow you're replying to an old post... ;)

17.01.2013 13:50, TeLeMan wrote:
> On Thu, May 12, 2011 at 10:44 PM, Michael Tokarev <address@hidden> wrote:
> > This patch almost rewrites acpi_table_add() function
[]
> > +
> > +    /* now read in the data files, reallocating buffer as needed */
> > +
> > +    for (f = strtok(buf, ":"); f; f = strtok(NULL, ":")) {
> > +        int fd = open(f, O_RDONLY);
>
> The acpi table is the binary file, so it should be opened by O_RDONLY
> | O_BINARY.

On Unix, O_BINARY is defined as 0, it has no effect whatsoever.
But yes it is a bug on other platforms.  I'll fix that in a moment.

Thanks,

/mnt