Re: [Qemu-devel] [RFC V1 11/12] qmp: Add block-pause-dedup.

[Benoît Canet]

> > +#
> > +# @device:   the name of the device to pause the deduplication on
> > +#
> > +# Returns: nothing on success
> > +#          If @device is not a valid block device, DeviceNotFound
> > +#          If @device is not deduplicated, DeviceNotDeduplicated
> 
> I don't think you need this second error.  A generic error is good
> enough unless we can prove that having a dedicated error class makes
> algorithmic sense for a given client, and I can't come up with such a
> scenario off the top of my head for libvirt.

Ok i'll remove it.

> 
> > +SQMP
> > +block-pause-dedup
> > +------------
> > +
> > +Pause the deduplication on a device that support it.
> 
> s/support/supports/
> 
> I notice that between this and patch 12, you are adding two very similar
> commands (block-pause-dedup, block-resume-dedup); would it be any
> simpler to add a single command instead:
> 
> { 'command': 'block-dedup-control',
>   'data': { 'device': 'str', 'enable': 'bool' } }
> 
> where the user calls:
> 
> { "execute": "block-dedup-control",
>   "arguments": { "device": "ide0-hd0", "enable": false } }
> 
> to pause, and "enable":true to resume?

Ok I'll merge these.

Regards

Benoît