[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] dataplane: fix build breakage on set_guest_
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] dataplane: fix build breakage on set_guest_notifiers() |
Date: |
Tue, 15 Jan 2013 08:23:25 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Jan 14, 2013 at 01:20:13PM -0600, Michael Roth wrote:
> virtio_pci_set_guest_notifiers() now takes an additional argument to
> specify the number of virtqueues to assign a guest notifier for. This
> causes a build breakage for CONFIG_VIRTIO_BLK_DATA_PLANE builds:
>
> /home/mdroth/w/qemu2.git/hw/dataplane/virtio-blk.c: In function
> ‘virtio_blk_data_plane_start’:
> /home/mdroth/w/qemu2.git/hw/dataplane/virtio-blk.c:451:47: error: too
> few arguments to function ‘s->vdev->binding->set_guest_notifiers’
> /home/mdroth/w/qemu2.git/hw/dataplane/virtio-blk.c: In function
> ‘virtio_blk_data_plane_stop’:
> /home/mdroth/w/qemu2.git/hw/dataplane/virtio-blk.c:511:5: error: too few
> arguments to function ‘s->vdev->binding->set_guest_notifiers’
> make[1]: *** [hw/dataplane/virtio-blk.o] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [subdir-x86_64-softmmu] Error 2
>
> Fix this by passing 1 as the number of virtqueues to assign notifiers
> for.
>
> Signed-off-by: Michael Roth <address@hidden>
> ---
> hw/dataplane/virtio-blk.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks for the fix, Mike!
Stefan