[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/6] qemu-ga: Handle errors uniformely in ga_cha
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 6/6] qemu-ga: Handle errors uniformely in ga_channel_open() |
Date: |
Mon, 14 Jan 2013 23:25:58 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) |
mdroth <address@hidden> writes:
> On Fri, Jan 11, 2013 at 11:25:02AM +0100, Markus Armbruster wrote:
>> We detect errors in seven places. One reports with g_error(), which
>
> Do you mean "in several places"? I can fix this in tree.
I counted seven places, but it doesn't really matter, "several" would be
fine, too.
>> calls abort(), the others report with g_critical(). Three of them
>> exit(), three return false.
>>
>> Always report with g_critical(), and return false.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>
> Reviewed-by: Michael Roth <address@hidden>
Thanks!
- [Qemu-devel] [PATCH 3/6] qemu-ga: Plug file descriptor leak on ga_open_pidfile() error path, (continued)
- [Qemu-devel] [PATCH 3/6] qemu-ga: Plug file descriptor leak on ga_open_pidfile() error path, Markus Armbruster, 2013/01/11
- [Qemu-devel] [PATCH 1/6] qemu-ga: Document intentional fall through in channel_event_cb(), Markus Armbruster, 2013/01/11
- [Qemu-devel] [PATCH 5/6] qemu-ga: Plug fd leak on ga_channel_open() error paths, Markus Armbruster, 2013/01/11
- [Qemu-devel] [PATCH 4/6] qemu-ga: Plug fd leak on ga_channel_listen_accept() error path, Markus Armbruster, 2013/01/11
- [Qemu-devel] [PATCH 6/6] qemu-ga: Handle errors uniformely in ga_channel_open(), Markus Armbruster, 2013/01/11
- Re: [Qemu-devel] [PATCH 0/6] Simple qemu-ga fixes and cleanups, Eric Blake, 2013/01/11
- Re: [Qemu-devel] [PATCH 0/6] Simple qemu-ga fixes and cleanups, Luiz Capitulino, 2013/01/14
- Re: [Qemu-devel] [PATCH 0/6] Simple qemu-ga fixes and cleanups, mdroth, 2013/01/14