[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V3 09/11] hmp: export function hmp_handle_error(
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH V3 09/11] hmp: export function hmp_handle_error() |
Date: |
Mon, 14 Jan 2013 16:38:51 -0200 |
On Mon, 14 Jan 2013 15:09:45 +0800
Wenchao Xia <address@hidden> wrote:
> Signed-off-by: Wenchao Xia <address@hidden>
This function is really a hmp.c-only helper. It does two more or less
unrelated things, I think it's better not to spread it over other
qemu source files.
> ---
> hmp.c | 2 +-
> hmp.h | 2 ++
> 2 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/hmp.c b/hmp.c
> index 2465d9b..89a1a8c 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -23,7 +23,7 @@
> #include "monitor/monitor.h"
> #include "ui/console.h"
>
> -static void hmp_handle_error(Monitor *mon, Error **errp)
> +void hmp_handle_error(Monitor *mon, Error **errp)
> {
> if (error_is_set(errp)) {
> monitor_printf(mon, "%s\n", error_get_pretty(*errp));
> diff --git a/hmp.h b/hmp.h
> index 5cab9c0..da1a35c 100644
> --- a/hmp.h
> +++ b/hmp.h
> @@ -17,7 +17,9 @@
> #include "qemu-common.h"
> #include "qapi-types.h"
> #include "qapi/qmp/qdict.h"
> +#include "qapi/error.h"
>
> +void hmp_handle_error(Monitor *mon, Error **errp);
> void hmp_info_name(Monitor *mon, const QDict *qdict);
> void hmp_info_version(Monitor *mon, const QDict *qdict);
> void hmp_info_kvm(Monitor *mon, const QDict *qdict);
- [Qemu-devel] [PATCH V3 07/11] block: export function bdrv_find_snapshot(), (continued)
- [Qemu-devel] [PATCH V3 07/11] block: export function bdrv_find_snapshot(), Wenchao Xia, 2013/01/14
- [Qemu-devel] [PATCH V3 06/11] qmp: add interface query-images., Wenchao Xia, 2013/01/14
- [Qemu-devel] [PATCH V3 11/11] hmp: show snapshot on single block device, Wenchao Xia, 2013/01/14
- [Qemu-devel] [PATCH V3 08/11] qmp: add interface query-snapshots, Wenchao Xia, 2013/01/14
- [Qemu-devel] [PATCH V3 10/11] hmp: retrieve info from qmp for snapshot info, Wenchao Xia, 2013/01/14
- [Qemu-devel] [PATCH V3 09/11] hmp: export function hmp_handle_error(), Wenchao Xia, 2013/01/14
- Re: [Qemu-devel] [PATCH V3 09/11] hmp: export function hmp_handle_error(),
Luiz Capitulino <=
- Re: [Qemu-devel] [PATCH V3 00/11] add qmp/hmp interfaces for snapshot info, Luiz Capitulino, 2013/01/14