[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/6] raw-posix: fix bdrv_aio_ioctl
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH 3/6] raw-posix: fix bdrv_aio_ioctl |
Date: |
Mon, 14 Jan 2013 11:01:58 +0100 |
From: Paolo Bonzini <address@hidden>
When the raw-posix aio=thread code was moved from posix-aio-compat.c
to block/raw-posix.c, there was an unintended change to the ioctl code.
The code used to return the ioctl command, which posix_aio_read()
would later morph into a zero. This hack is not necessary anymore,
and in fact breaks scsi-generic (which expects a zero return code).
Remove it.
Cc: address@hidden
Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
block/raw-posix.c | 10 +---------
1 files changed, 1 insertions(+), 9 deletions(-)
diff --git a/block/raw-posix.c b/block/raw-posix.c
index 87d888e..0e705ba 100644
--- a/block/raw-posix.c
+++ b/block/raw-posix.c
@@ -455,15 +455,7 @@ static ssize_t handle_aiocb_ioctl(RawPosixAIOData *aiocb)
return -errno;
}
- /*
- * This looks weird, but the aio code only considers a request
- * successful if it has written the full number of bytes.
- *
- * Now we overload aio_nbytes as aio_ioctl_cmd for the ioctl command,
- * so in fact we return the ioctl command here to make posix_aio_read()
- * happy..
- */
- return aiocb->aio_nbytes;
+ return 0;
}
static ssize_t handle_aiocb_flush(RawPosixAIOData *aiocb)
--
1.7.6.5
- [Qemu-devel] [PULL 0/6] Block patches, Kevin Wolf, 2013/01/14
- [Qemu-devel] [PATCH 1/6] block: do not probe zero-sized disks, Kevin Wolf, 2013/01/14
- [Qemu-devel] [PATCH 2/6] sheepdog: implement direct write semantics, Kevin Wolf, 2013/01/14
- [Qemu-devel] [PATCH 4/6] block: make qiov_is_aligned() public, Kevin Wolf, 2013/01/14
- [Qemu-devel] [PATCH 5/6] dataplane: extract virtio-blk read/write processing into do_rdwr_cmd(), Kevin Wolf, 2013/01/14
- [Qemu-devel] [PATCH 3/6] raw-posix: fix bdrv_aio_ioctl,
Kevin Wolf <=
- [Qemu-devel] [PATCH 6/6] dataplane: handle misaligned virtio-blk requests, Kevin Wolf, 2013/01/14
- Re: [Qemu-devel] [PULL 0/6] Block patches, Anthony Liguori, 2013/01/20