Re: [Qemu-devel] Fix the glib deprecated APIs

[Stefan Hajnoczi]

On Fri, Jan 11, 2013 at 06:01:53PM +0100, Paolo Bonzini wrote:
> Il 11/01/2013 17:10, Ramesh G ha scritto:
> > 
> > Hi,
> > 
> > I got a couple of below compilation errors while compiling with glib >
> > 2.32.  
> > 
> > $ make
> >   CC    ../trace/simple.o
> > ../trace/simple.c: In function ‘trace_thread_create’:
> > ../trace/simple.c:407:5: error: ‘g_thread_create’ is deprecated
> > (declared at /usr/include/glib-2.0/glib/deprecated/gthread.h:100): Use
> > 'g_thread_new' instead [-Werror=deprecated-declarations]
> > ../trace/simple.c: In function ‘trace_backend_init’:
> > ../trace/simple.c:428:5: error: ‘g_cond_new’ is deprecated (declared at
> > /usr/include/glib-2.0/glib/deprecated/gthread.h:275)
> > [-Werror=deprecated-declarations]
> > ../trace/simple.c:429:5: error: ‘g_cond_new’ is deprecated (declared at
> > /usr/include/glib-2.0/glib/deprecated/gthread.h:275)
> > [-Werror=deprecated-declarations]
> > cc1: all warnings being treated as errors
> > make: *** [../trace/simple.o] Error 1
> > $ 
> > 
> > I found these APIs have been deprecated in 2.32.  Please find the patch
> > attached which fixes this problem.  Please let me know your thoughts.
> 
> Could you instead change it to use qemu-thread?

The reason to avoid QEMU APIs is to prevent entering an infinite loop if
a trace event is placed into the qemu-thread code.

Stefan