[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 08/10] chardev: add parallel chardev support to c
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PATCH v3 08/10] chardev: add parallel chardev support to chardev-add (qmp) |
Date: |
Fri, 11 Jan 2013 12:20:17 +0100 |
Also alias the old parport name to parallel for -chardev.
Signed-off-by: Gerd Hoffmann <address@hidden>
---
qapi-schema.json | 3 ++-
qemu-char.c | 44 ++++++++++++++++++++++++++++----------------
qemu-options.hx | 5 ++++-
3 files changed, 34 insertions(+), 18 deletions(-)
diff --git a/qapi-schema.json b/qapi-schema.json
index bbbbd33..320fa6b 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -3042,7 +3042,8 @@
#
# Since: 1.4
##
-{ 'enum': 'ChardevPortKind', 'data': [ 'serial' ] }
+{ 'enum': 'ChardevPortKind', 'data': [ 'serial',
+ 'parallel' ] }
{ 'type': 'ChardevPort', 'data': { 'device' : 'str',
'type' : 'ChardevPortKind'} }
diff --git a/qemu-char.c b/qemu-char.c
index b72f968..666ae18 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -1367,17 +1367,10 @@ static void pp_close(CharDriverState *chr)
qemu_chr_be_event(chr, CHR_EVENT_CLOSED);
}
-static CharDriverState *qemu_chr_open_pp(QemuOpts *opts)
+static CharDriverState *qemu_chr_open_pp_fd(int fd)
{
- const char *filename = qemu_opt_get(opts, "path");
CharDriverState *chr;
ParallelCharDriver *drv;
- int fd;
-
- TFR(fd = qemu_open(filename, O_RDWR));
- if (fd < 0) {
- return NULL;
- }
if (ioctl(fd, PPCLAIM) < 0) {
close(fd);
@@ -1441,16 +1434,9 @@ static int pp_ioctl(CharDriverState *chr, int cmd, void
*arg)
return 0;
}
-static CharDriverState *qemu_chr_open_pp(QemuOpts *opts)
+static CharDriverState *qemu_chr_open_pp_fd(int fd)
{
- const char *filename = qemu_opt_get(opts, "path");
CharDriverState *chr;
- int fd;
-
- fd = qemu_open(filename, O_RDWR);
- if (fd < 0) {
- return NULL;
- }
chr = g_malloc0(sizeof(CharDriverState));
chr->opaque = (void *)(intptr_t)fd;
@@ -2750,6 +2736,22 @@ fail:
return NULL;
}
+#ifdef HAVE_CHARDEV_PARPORT
+
+static CharDriverState *qemu_chr_open_pp(QemuOpts *opts)
+{
+ const char *filename = qemu_opt_get(opts, "path");
+ int fd;
+
+ fd = qemu_open(filename, O_RDWR);
+ if (fd < 0) {
+ return NULL;
+ }
+ return qemu_chr_open_pp_fd(fd);
+}
+
+#endif
+
static const struct {
const char *name;
CharDriverState *(*open)(QemuOpts *opts);
@@ -2779,6 +2781,7 @@ static const struct {
{ .name = "pty", .open = qemu_chr_open_pty },
#endif
#ifdef HAVE_CHARDEV_PARPORT
+ { .name = "parallel", .open = qemu_chr_open_pp },
{ .name = "parport", .open = qemu_chr_open_pp },
#endif
#ifdef CONFIG_SPICE
@@ -3031,6 +3034,15 @@ static CharDriverState
*qmp_chardev_open_port(ChardevPort *port, Error **errp)
socket_set_nonblock(fd);
return qemu_chr_open_tty_fd(fd);
#endif
+#ifdef HAVE_CHARDEV_PARPORT
+ case CHARDEV_PORT_KIND_PARALLEL:
+ flags = O_RDWR;
+ fd = qmp_chardev_open_file_source(port->device, flags, errp);
+ if (error_is_set(errp)) {
+ return NULL;
+ }
+ return qemu_chr_open_pp_fd(fd);
+#endif
default:
error_setg(errp, "unknown chardev port (%d)", port->type);
return NULL;
diff --git a/qemu-options.hx b/qemu-options.hx
index 17cc1ad..40cd683 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -1746,6 +1746,7 @@ DEF("chardev", HAS_ARG, QEMU_OPTION_chardev,
"-chardev tty,id=id,path=path[,mux=on|off]\n"
#endif
#if defined(__linux__) || defined(__FreeBSD__) || defined(__DragonFly__)
+ "-chardev parallel,id=id,path=path[,mux=on|off]\n"
"-chardev parport,id=id,path=path[,mux=on|off]\n"
#endif
#if defined(CONFIG_SPICE)
@@ -1776,6 +1777,7 @@ Backend is one of:
@option{stdio},
@option{braille},
@option{tty},
address@hidden,
@option{parport},
@option{spicevmc}.
@option{spiceport}.
@@ -1943,9 +1945,10 @@ DragonFlyBSD hosts. It is an alias for -serial.
@option{path} specifies the path to the tty. @option{path} is required.
address@hidden -chardev parallel ,address@hidden ,address@hidden
@item -chardev parport ,address@hidden ,address@hidden
address@hidden is only available on Linux, FreeBSD and DragonFlyBSD hosts.
address@hidden is only available on Linux, FreeBSD and DragonFlyBSD hosts.
Connect to a local parallel port.
--
1.7.1
- [Qemu-devel] [PATCH v3 00/10] chardev hotplug patch series, Gerd Hoffmann, 2013/01/11
- [Qemu-devel] [PATCH v3 05/10] chardev: add hmp hotplug commands, Gerd Hoffmann, 2013/01/11
- [Qemu-devel] [PATCH v3 06/10] chardev: add file chardev support to chardev-add (qmp), Gerd Hoffmann, 2013/01/11
- [Qemu-devel] [PATCH v3 09/10] chardev: add socket chardev support to chardev-add (qmp), Gerd Hoffmann, 2013/01/11
- [Qemu-devel] [PATCH v3 04/10] chardev: add qmp hotplug commands, with null chardev support, Gerd Hoffmann, 2013/01/11
- [Qemu-devel] [PATCH v3 10/10] chardev: add pty chardev support to chardev-add (qmp), Gerd Hoffmann, 2013/01/11
- [Qemu-devel] [PATCH v3 07/10] chardev: add serial chardev support to chardev-add (qmp), Gerd Hoffmann, 2013/01/11
- [Qemu-devel] [PATCH v3 03/10] chardev: reduce chardev ifdef mess a bit, Gerd Hoffmann, 2013/01/11
- [Qemu-devel] [PATCH v3 02/10] chardev: fix QemuOpts lifecycle, Gerd Hoffmann, 2013/01/11
- [Qemu-devel] [PATCH v3 08/10] chardev: add parallel chardev support to chardev-add (qmp),
Gerd Hoffmann <=
- [Qemu-devel] [PATCH v3 01/10] chardev: add error reporting for qemu_chr_new_from_opts, Gerd Hoffmann, 2013/01/11
- Re: [Qemu-devel] [PATCH v3 00/10] chardev hotplug patch series, Eric Blake, 2013/01/11