[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 06/10] chardev: add file chardev support to c
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 06/10] chardev: add file chardev support to chardev-add (qmp) |
Date: |
Thu, 10 Jan 2013 12:33:45 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 |
On 01/10/2013 07:23 AM, Gerd Hoffmann wrote:
> Add support for file chardevs. Output file is mandatory,
> input file is optional.
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> qapi-schema.json | 13 ++++++++++-
> qemu-char.c | 61
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> qmp-commands.hx | 8 ++++++-
> 3 files changed, 80 insertions(+), 2 deletions(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 53d4b9e..7930139 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -3019,6 +3019,16 @@
> { 'command': 'nbd-server-stop' }
>
> ##
> +# @ChardevFile:
Should you mention '@in: #optional' and '@out:' in any further detail?
> +#
> +# Configuration info for file chardevs.
> +#
> +# Since: 1.4
> +##
> +{ 'type': 'ChardevFile', 'data': { '*in' : 'str',
> + 'out' : 'str' } }
Hmm; here you document ChardevFile as a separate type, but you didn't
document ChardevDummy in patch 4/10.
> +#ifdef _WIN32
> +
> +#else /* WIN32 */
Wouldn't this be /* !_WIN32 */?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 09/10] chardev: add socket chardev support to chardev-add (qmp), (continued)
- [Qemu-devel] [PATCH v2 09/10] chardev: add socket chardev support to chardev-add (qmp), Gerd Hoffmann, 2013/01/10
- [Qemu-devel] [PATCH v2 01/10] chardev: add error reporting for qemu_chr_new_from_opts, Gerd Hoffmann, 2013/01/10
- [Qemu-devel] [PATCH v2 08/10] chardev: add parallel chardev support to chardev-add (qmp), Gerd Hoffmann, 2013/01/10
- [Qemu-devel] [PATCH v2 02/10] chardev: fix QemuOpts lifecycle, Gerd Hoffmann, 2013/01/10
- [Qemu-devel] [PATCH v2 06/10] chardev: add file chardev support to chardev-add (qmp), Gerd Hoffmann, 2013/01/10
- Re: [Qemu-devel] [PATCH v2 06/10] chardev: add file chardev support to chardev-add (qmp),
Eric Blake <=
- [Qemu-devel] [PATCH v2 03/10] chardev: reduce chardev ifdef mess a bit, Gerd Hoffmann, 2013/01/10
- [Qemu-devel] [PATCH v2 04/10] chardev: add qmp hotplug commands, with null chardev support, Gerd Hoffmann, 2013/01/10
- [Qemu-devel] [PATCH v2 10/10] chardev: add pty chardev support to chardev-add (qmp), Gerd Hoffmann, 2013/01/10