Re: [Qemu-devel] [RFC PATCH 0/2] make mac programming for virtio net more robust

[Michael S. Tsirkin]

On Thu, Jan 10, 2013 at 10:45:39PM +0800, address@hidden wrote:
> From: Amos Kong <address@hidden>
> 
> Currenly mac is programmed byte by byte. This means that we
> have an intermediate step where mac is wrong. 
> 
> Second patch introduced a new vq control command to set mac
> address in one time.

As you mention we could alternatively do it without
new commands, simply add a feature bit that says that MACs are
in the mac table.
This would be a much bigger patch, and I'm fine with either way.
Rusty what do you think?

> Amos Kong (2):
>   move virtnet_send_command() above virtnet_set_mac_address()
>   virtio-net: introduce a new control to set macaddr
> 
>  drivers/net/virtio_net.c        | 105 
> ++++++++++++++++++++++------------------
>  include/uapi/linux/virtio_net.h |   8 ++-
>  2 files changed, 66 insertions(+), 47 deletions(-)
> 
> -- 
> 1.7.11.7