[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/11] chardev: add socket chardev support to ch
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 10/11] chardev: add socket chardev support to chardev-add (qmp) |
Date: |
Thu, 10 Jan 2013 10:12:53 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.11) Gecko/20121116 Thunderbird/10.0.11 |
Hi,
>> -static CharDriverState *qemu_chr_open_socket(QemuOpts *opts)
>> +static CharDriverState *qemu_chr_open_socket_fd(int fd, int
>> do_nodelay, + int
>> is_listen, int is_telnet, +
>> int is_waitconnect,
>
> These three parameters sound like they might be better as 'bool'
> instead of 'int'.
Just continuing to do what the existing code did.
>> @@ -2458,10 +2536,7 @@ static CharDriverState
>> *qemu_chr_open_socket(QemuOpts *opts) if (!is_listen)
>> is_waitconnect = 0;
>>
>> - chr = g_malloc0(sizeof(CharDriverState)); - s =
>> g_malloc0(sizeof(TCPCharDriver)); - - if (is_unix) { + if
>> (is_unix) {
>
> Spurious re-indentation?
Seems so, I'll check.
cheers,
Gerd
- Re: [Qemu-devel] [PATCH 09/11] chardev: add parport chardev support to chardev-add (qmp), (continued)
- [Qemu-devel] [PATCH 10/11] chardev: add socket chardev support to chardev-add (qmp), Gerd Hoffmann, 2013/01/07
- [Qemu-devel] [PATCH 07/11] chardev: add tty chardev support to chardev-add (qmp), Gerd Hoffmann, 2013/01/07
- [Qemu-devel] [PATCH 03/11] chardev: reduce chardev ifdef mess a bit, Gerd Hoffmann, 2013/01/07
- [Qemu-devel] [PATCH 11/11] chardev: add pty chardev support to chardev-add (qmp), Gerd Hoffmann, 2013/01/07
- [Qemu-devel] [PATCH 06/11] chardev: add file chardev support to chardev-add (qmp), Gerd Hoffmann, 2013/01/07