[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 02/12] qemu-ga: qmp_guest_file_close(): fix fclose()
From: |
Michael Roth |
Subject: |
[Qemu-devel] [PATCH 02/12] qemu-ga: qmp_guest_file_close(): fix fclose() error check |
Date: |
Tue, 8 Jan 2013 16:59:59 -0600 |
From: Luiz Capitulino <address@hidden>
fclose() returns EOF on error.
Signed-off-by: Luiz Capitulino <address@hidden>
Reviewed-by: Michael Roth <address@hidden>
Signed-off-by: Michael Roth <address@hidden>
---
qga/commands-posix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index bbef66d..ebb58be 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -170,7 +170,7 @@ void qmp_guest_file_close(int64_t handle, Error **err)
}
ret = fclose(gfh->fh);
- if (ret == -1) {
+ if (ret == EOF) {
error_set(err, QERR_QGA_COMMAND_FAILED, "fclose() failed");
return;
}
--
1.7.9.5
- [Qemu-devel] [PULL 0/12] qemu-ga: error handling improvements and fsfreeze hooks, Michael Roth, 2013/01/08
- [Qemu-devel] [PATCH 01/12] qemu-ga: guest_file_handle_find(): take an Error argument, Michael Roth, 2013/01/08
- [Qemu-devel] [PATCH 02/12] qemu-ga: qmp_guest_file_close(): fix fclose() error check,
Michael Roth <=
- [Qemu-devel] [PATCH 03/12] qemu-ga: qmp_guest_file_*: improve error reporting, Michael Roth, 2013/01/08
- [Qemu-devel] [PATCH 04/12] qemu-ga: qmp_guest_shutdown(): improve error reporting, Michael Roth, 2013/01/08
- [Qemu-devel] [PATCH 05/12] qemu-ga: build_fs_mount_list(): take an Error argument, Michael Roth, 2013/01/08
- [Qemu-devel] [PATCH 06/12] qemu-ga: qmp_guest_fsfreeze_*(): get rid of sprintf() + error_set(), Michael Roth, 2013/01/08
- [Qemu-devel] [PATCH 08/12] qemu-ga: qmp_guest_network_get_interfaces(): get rid of snprintf() + error_set(), Michael Roth, 2013/01/08
- [Qemu-devel] [PATCH 09/12] qemu-ga: bios_supports_mode(): improve error reporting, Michael Roth, 2013/01/08
- [Qemu-devel] [PATCH 07/12] qemu-ga: qmp_guest_fstrim(): get rid of sprintf() + error_set(), Michael Roth, 2013/01/08
- [Qemu-devel] [PATCH 10/12] qemu-ga: guest_suspend(): improve error reporting, Michael Roth, 2013/01/08
- [Qemu-devel] [PATCH 11/12] qemu-ga: execute hook to quiesce the guest on fsfreeze-freeze/thaw, Michael Roth, 2013/01/08