Re: [Qemu-devel] [PATCH 10/12] virtio-net: multiqueue support

[Jason Wang]

On 01/08/2013 05:07 PM, Wanlong Gao wrote:
> On 12/28/2012 06:32 PM, Jason Wang wrote:
>> +    } else if (nc->peer->info->type !=  NET_CLIENT_OPTIONS_KIND_TAP) {
>> +        ret = -1;
>> +    } else {
>> +        ret = tap_detach(nc->peer);
>> +    }
>> +
>> +    return ret;
>> +}
>> +
>> +static void virtio_net_set_queues(VirtIONet *n)
>> +{
>> +    int i;
>> +
>> +    for (i = 0; i < n->max_queues; i++) {
>> +        if (i < n->curr_queues) {
>> +            assert(!peer_attach(n, i));
>> +        } else {
>> +            assert(!peer_detach(n, i));
> I got a assert here,
> qemu-system-x86_64: /work/git/qemu/hw/virtio-net.c:330: 
> virtio_net_set_queues: Assertion `!peer_detach(n, i)' failed.
>
> Any thoughts?
>
> Thanks,
> Wanlong Gao

Thanks for the testing, which steps or cases did you met this assertion,
migration, reboot or just changing the number of virtqueues?

>> +        }
>> +    }
>> +}
>> +
>> +static void virtio_net_set_multiqueue(VirtIONet *n, int multiqueue, int 
>> ctrl);
>> +
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to address@hidden
> More majordomo info at  http://vger.kernel.org/majordomo-info.html