Re: [Qemu-devel] [PATCH] qdev: obey no_user

[Andreas Färber]

Am 07.01.2013 21:16, schrieb Peter Maydell:
> On 7 January 2013 20:12, Anthony Liguori <address@hidden> wrote:
>> Peter Maydell <address@hidden> writes:
>>> It seems to me like arbitrarily allowing the monitor to construct
>>> no-user devices isn't really the right way to attack the problem
>>> of "allow complete machine construction by management tools"...
>>
>> There is no such thing as a 'no-user' device.  It's a silly distinction
>> that has never had a consistent meaning.
> 
> Then let's just rip that flag out completely.

That's a bad idea, given that we are about to make the CPU a device.

So yes, there are devices that are not meant to be instantiated more
than once (e.g., sclp-console). And there are devices that are not meant
to be instantiated by the user at all.

BTW this patch exposed that there is silly code in this function: When
the bus is NULL, it is initialized as the SysBus. But we all know that
SysBus is not hotplug-capable in the first place, so we can never
device_add on SysBus.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg