Re: [Qemu-devel] [PATCH 28/32] softmmu: move include files to include/sysemu/

[Amos Kong]

On Thu, Dec 06, 2012 at 02:07:06PM +0100, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  arch_init.c                                        |    6 +++---
>  audio/audio.c                                      |    2 +-
>  audio/winwaveaudio.c                               |    2 +-
>  balloon.c                                          |    4 ++--
>  block-migration.c                                  |    2 +-

...

>  hw/z2.c                                            |    4 ++--
>  hw/zynq_slcr.c                                     |    2 +-
>  include/exec/exec-memory.h                         |    2 +-
>  include/exec/softmmu_template.h                    |    2 +-
>  arch_init.h => include/sysemu/arch_init.h          |    0

Failed to compile latest qemu(8e4a424b305e29dc0e454f52df3b35577f342975) on 
Fedora17
$ rpm -q gcc
gcc-4.7.2-2.fc17.x86_64

It's fine in RHEL.
# rpm -q gcc
gcc-4.4.6-4.el6.x86_64

Include issue of gcc ?


# ./configure --target-list=x86_64-softmmu --enable-debug
# make
  ...
  CC    x86_64-softmmu/arch_init.o
In file included from /home/devel/qemu/include/sysemu/arch_init.h:4:0,
                 from /home/devel/qemu/arch_init.c:36:
./qmp-commands.h:3:1: error: expected identifier or ‘(’ before ‘{’ token
./qmp-commands.h:10:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:20:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:30:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:40:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:50:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:60:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:70:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:80:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:90:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:100:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:110:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:120:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:130:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:140:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:154:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:164:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:174:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:184:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:194:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:204:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:214:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:224:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:233:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:244:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:254:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:264:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:274:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:284:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:294:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:304:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:314:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:323:2: error: expected identifier or ‘(’ before ‘,’ token
./qmp-commands.h:333:2: error: expected identifier or ‘(’ before ‘,’ token
/home/devel/qemu/arch_init.c:104:28: error: ‘QEMU_ARCH_I386’ undeclared here 
(not in a function)
make[1]: *** [arch_init.o] Error 1
make: *** [subdir-x86_64-softmmu] Error 2


Amos