[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] spice: drop incorrect vm_change_state_handler()
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH] spice: drop incorrect vm_change_state_handler() opaque |
|
Date: |
Thu, 3 Jan 2013 11:57:49 +0100 |
On Thu, Jan 3, 2013 at 9:20 AM, Gerd Hoffmann <address@hidden> wrote:
> On 01/02/13 16:56, Stefan Hajnoczi wrote:
>> On Wed, Dec 19, 2012 at 02:07:16PM +0100, Stefan Hajnoczi wrote:
>>> The spice_server pointer is a global variable and
>>> vm_change_state_handler() therefore does not use its opaque parameter.
>>>
>>> The vm change state handler is added with a pointer to the spice_server
>>> pointer. This is useless and we probably would not want 2 levels of
>>> pointers.
>
>> Gerd, would you like to take this through the spice queue or should I
>> put it in trivial-patches?
>
> Taking through trivial is fine with me, especially as the spice patch
> queue is empty atm ;)
Okay, I'll take it. Thanks!
Stefan