Re: [Qemu-devel] [PATCH] linux-user/syscall.c: remove forward declarations

[Amos Kong]

On Wed, Dec 26, 2012 at 7:49 AM, John Spencer <address@hidden> wrote:
>
> instead use the correct headers that define these functions.
>
> Requested-by: Stefan Weil <address@hidden>
> Signed-off-by: John Spencer <address@hidden>
> ---
>  linux-user/syscall.c |    8 +++-----
>  1 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index e99adab..3167a87 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -36,6 +36,9 @@
>  #include <sys/time.h>
>  #include <sys/stat.h>
>  #include <sys/mount.h>
> +#include <sys/file.h>
> +#include <sys/fsuid.h>
> +#include <sys/personality.h>
>  #include <sys/prctl.h>
>  #include <sys/resource.h>
>  #include <sys/mman.h>
> @@ -581,11 +584,6 @@ _syscall4(int, sys_prlimit64, pid_t, pid, int, resource,
>            struct host_rlimit64 *, old_limit)
>  #endif
>
> -extern int personality(int);
> -extern int flock(int, int);
> -extern int setfsuid(int);
> -extern int setfsgid(int);
> -

Reviewed-by: Amos Kong <address@hidden>

>  /* ARM EABI and MIPS expect 64bit types aligned even on pairs or registers */
>  #ifdef TARGET_ARM
>  static inline int regpairs_aligned(void *cpu_env) {
> --
> 1.7.3.4
>
>