[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/8] qdev-properties.c: Separate core from the c
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 6/8] qdev-properties.c: Separate core from the code used only by qemu-system-* |
Date: |
Tue, 18 Dec 2012 23:30:02 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 |
Am 05.12.2012 17:49, schrieb Eduardo Habkost:
> This separates the qdev properties code in two parts:
> - qdev-properties.c, that contains most of the qdev properties code;
> - qdev-properties-system.c for code specific for qemu-system-*,
> containing:
> - Property types: drive, chr, netdev, vlan, that depend on code that
> won't be included on *-user
> - qemu_add_globals(), that depends on qemu-config.o.
>
> This change should help on two things:
> - Allowing DeviceState to be used by *-user without pulling
> dependencies that are specific for qemu-system-*;
> - Writing qdev unit tests without pulling too many dependencies.
>
> The copyright/license of qdev-properties.c isn't explicitly stated at
> the file, so add a simple copyright/license header pointing to the
> commit ID of the original file.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
I dropped a trailing white line in qdev-properties-system.c; otherwise
it passed checkpatch.pl cleanly now. I verified that nothing got lost or
accidentally changed during the code movement.
Thanks, applied to qom-cpu queue:
https://github.com/afaerber/qemu-cpu/commits/qom-cpu
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- Re: [Qemu-devel] [PATCH 8/8] qom: Make CPU a child of DeviceState, (continued)
[Qemu-devel] [PATCH 7/8] include qdev code into *-user, too, Eduardo Habkost, 2012/12/05
[Qemu-devel] [PATCH 3/8] libqemustub: vmstate register/unregister stubs, Eduardo Habkost, 2012/12/05
[Qemu-devel] [PATCH 1/8] Move -I$(SRC_PATH)/include compiler flag to Makefile.objs, Eduardo Habkost, 2012/12/05
[Qemu-devel] [PATCH 6/8] qdev-properties.c: Separate core from the code used only by qemu-system-*, Eduardo Habkost, 2012/12/05
- Re: [Qemu-devel] [PATCH 6/8] qdev-properties.c: Separate core from the code used only by qemu-system-*,
Andreas Färber <=