Re: [Qemu-devel] [PATCH] block/raw-win32: Fix compiler warnings (wrong format specifiers)

[Andreas Färber]

Am 17.12.2012 20:40, schrieb Stefan Weil:
> Commit fbcad04d6bfdff937536eb23088a01a280a1a3af added fprintf statements
> with wrong format specifiers.
> 
> GetLastError() returns a DWORD which is unsigned long, so %lu must be used.
> 
> Signed-off-by: Stefan Weil <address@hidden>
> ---
> 
> Do we want those fprintf statements here at all?

I believe it was argued that otherwise you cannot distinguish where the
EIO came from.

Andreas

>  block/raw-win32.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/block/raw-win32.c b/block/raw-win32.c
> index ce207a3..a2e155e 100644
> --- a/block/raw-win32.c
> +++ b/block/raw-win32.c
> @@ -314,11 +314,11 @@ static int raw_truncate(BlockDriverState *bs, int64_t 
> offset)
>       */
>      dwPtrLow = SetFilePointer(s->hfile, low, &high, FILE_BEGIN);
>      if (dwPtrLow == INVALID_SET_FILE_POINTER && GetLastError() != NO_ERROR) {
> -        fprintf(stderr, "SetFilePointer error: %d\n", GetLastError());
> +        fprintf(stderr, "SetFilePointer error: %lu\n", GetLastError());
>          return -EIO;
>      }
>      if (SetEndOfFile(s->hfile) == 0) {
> -        fprintf(stderr, "SetEndOfFile error: %d\n", GetLastError());
> +        fprintf(stderr, "SetEndOfFile error: %lu\n", GetLastError());
>          return -EIO;
>      }
>      return 0;
> 


-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg