[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/17] qapi: Convert savevm, loadvm, delvm an
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/17] qapi: Convert savevm, loadvm, delvm and info snapshots |
Date: |
Fri, 14 Dec 2012 15:24:24 -0200 |
On Thu, 13 Dec 2012 16:40:34 +0100
Pavel Hrdina <address@hidden> wrote:
> This patch series convert these commands into qapi and introduce QMP commands
> vm-snapshot-save, vm-snapshot-load, vm-snapshot-delete and query-vm-snapshots.
> It also rewrite error report for functions used by these commands.
I've reviewed most of this series and identified several problems, but I
think that the major problem here is that this series is doing too much at
once.
A properly done and split series would easily reach twice as many patches
this series currently has.
So, my main advice here is to start simple. You could take one of savevm,
delvm or loadvm and convert it to propagate errors internally.
Also note that this series doesn't build:
CC x86_64-softmmu/savevm.o
/home/lcapitulino/work/src/qmp-unstable/savevm.c: In function
‘qmp_vm_snapshot_load’:
/home/lcapitulino/work/src/qmp-unstable/savevm.c:2274:9: error: variable ‘ret’
set but not used [-Werror=unused-but-set-variable]
cc1: all warnings being treated as errors
make[1]: *** [savevm.o] Error 1
make: *** [subdir-x86_64-softmmu] Error 2
- [Qemu-devel] [PATCH v2 11/17] savevm: add error parameter to qemu_savevm_state(), (continued)
- [Qemu-devel] [PATCH v2 11/17] savevm: add error parameter to qemu_savevm_state(), Pavel Hrdina, 2012/12/13
- [Qemu-devel] [PATCH v2 13/17] qapi: Convert savevm, Pavel Hrdina, 2012/12/13
- [Qemu-devel] [PATCH v2 10/17] savevm: add error parameter to qemu_savevm_state_complete(), Pavel Hrdina, 2012/12/13
- [Qemu-devel] [PATCH v2 17/17] vm-snapshot-save: add force parameter, Pavel Hrdina, 2012/12/13
- [Qemu-devel] [PATCH v2 14/17] qapi: Convert loadvm, Pavel Hrdina, 2012/12/13
- [Qemu-devel] [PATCH v2 15/17] qapi: Convert delvm, Pavel Hrdina, 2012/12/13
- Re: [Qemu-devel] [PATCH v2 00/17] qapi: Convert savevm, loadvm, delvm and info snapshots,
Luiz Capitulino <=
- Re: [Qemu-devel] [PATCH v2 00/17] qapi: Convert savevm, loadvm, delvm and info snapshots, Wenchao Xia, 2012/12/19