[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support.
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support. |
Date: |
Fri, 14 Dec 2012 14:18:36 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.11) Gecko/20121116 Thunderbird/10.0.11 |
Hi,
> { 'enum': 'ChardevFileMode', 'data':
> # pty = console under Windows
> # serial = tty under POSIX
> [ 'file', 'pipe', 'parport', 'pty', 'serial' ] }
Hmm, why this enum? I'd stay close to -chardev, i.e. specify the type
by backend name.
> { 'enum: 'ChardevFileSource', 'data':
> [ 'path', 'fd' ] }
I guess I'd just create a new backend type for file descriptor passing
instead of fitting that into all the existing ones.
> { 'union': 'ChardevBackend', 'data': {
This union thing is new, isn't it?
Makes sense to use that indeed.
> 'socket': 'ChardevSocket',
> 'udp': 'UDPSocketAddress',
> 'file': 'ChardevFile',
> 'null': 'ChardevDummy',
> 'msmouse': 'ChardevDummy',
> 'braille': 'ChardevDummy',
> 'stdio': 'ChardevDummy',
> 'vc': 'ChardevVC',
I doubt we need them all hotpluggable.
cheers,
Gerd
0001-chardev-add-hotplug-support.patch
Description: Text document
- [Qemu-devel] [PATCH RESENT 0/3] chardev hotplug patch series, Gerd Hoffmann, 2012/12/14
- [Qemu-devel] [PATCH 2/3] chardev: fix QemuOpts lifecycle, Gerd Hoffmann, 2012/12/14
- [Qemu-devel] [PATCH 1/3] chardev: add error reporting for qemu_chr_new_from_opts, Gerd Hoffmann, 2012/12/14
- [Qemu-devel] [PATCH 3/3] chardev: add hotplug support., Gerd Hoffmann, 2012/12/14
- Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support., Paolo Bonzini, 2012/12/14
- Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support., Eric Blake, 2012/12/14
- Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support.,
Gerd Hoffmann <=
- Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support., Paolo Bonzini, 2012/12/14
- Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support., Gerd Hoffmann, 2012/12/14
- Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support., Gerd Hoffmann, 2012/12/14
- Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support., Paolo Bonzini, 2012/12/14