Re: [Qemu-devel] [PATCH 1/3] target-i386: add EXT2_PPRO_FEATURES #define

[Andreas Färber]

Am 12.12.2012 23:22, schrieb Eduardo Habkost:
> Instead of repeating the (PPRO_FEATURES & CPUID_EXT2_AMD_ALIASES)
> expression everywhere, use EXT2_PPRO_FEATURES.
> 
> Signed-off-by: Eduardo Habkost <address@hidden>

Technically this patch looks fine. My dislike for these defines aside, I
have doubts about the semantics: This is masking out "AMD_ALIASES"
(whatever that is exactly I still need to look up) - doesn't that rather
call for EXT2_PPRO_INTEL_FEATURES or so? (But then again the Pentium Pro
was an Intel chip so AMD sounds confusing...) Or does no AMD model
actually inherit those AMD aliases? This at least deserves a mention in
the commit message (no need to resend then).

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg