[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version |
Date: |
Thu, 13 Dec 2012 16:30:20 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.11) Gecko/20121116 Thunderbird/10.0.11 |
Hi,
> 6e72719e721a40fe1224701ca10edc1caf0cd708
It's broken, version is wrong, and I told you.
Seems you sneaked it in nevertheless.
> You had 2 branches that were using a new flag, one of which you had
> an #ifdef around and one of which you didn't. This is all fixed for
> quite a while now :).
Can you check which of your pixman versions have PIXMAN_TYPE_BGRA?
0.18.4 has it
0.12.0 has not
The 0.16.x versions would be interesting so we can fix the #ifdef to be
correct (or at least correct enougth for all practical purposes).
> If that's the culprit for all this mess, can we remove the configure
> check again? QEMU compiles just fine without it today on pixman
> 0.12.0.
If you send me a fix for 6e72719e721a40fe1224701ca10edc1caf0cd708 I'll
go revert 288fa40736e6eb63132d01aa6dc21ee831b796ae
cheers,
Gerd
- [Qemu-devel] [PATCH 0/2] pixman: two little fixes., Gerd Hoffmann, 2012/12/10
- [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version, Gerd Hoffmann, 2012/12/10
- Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version, Alexander Graf, 2012/12/13
- Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version, Gerd Hoffmann, 2012/12/13
- Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version, Alexander Graf, 2012/12/13
- Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version,
Gerd Hoffmann <=
- Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version, Alexander Graf, 2012/12/13
- Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version, Gerd Hoffmann, 2012/12/14
- Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version, Alexander Graf, 2012/12/14
- Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version, Alexander Graf, 2012/12/13
[Qemu-devel] [PATCH 2/2] pixman: update internal copy to pixman-0.28.2, Gerd Hoffmann, 2012/12/10