Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version

[Alexander Graf]

On 10.12.2012, at 13:48, Gerd Hoffmann wrote:

> Lower the bar a bit.  0.16.4 is known-good, and is shipped by debian.
> Fixes build failures on the debian-based buildbot slaves.

SLES11 ships 0.16.0 for example. It'd be nice to stay compatible there.

What exactly is the compatibility bar? The fact that it compiles? Without the 
configure check it's compiling just fine on 0.12.0 (openSUSE 11.1) here.


Alex

> 
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> configure |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index e5aedef..a4e62c4 100755
> --- a/configure
> +++ b/configure
> @@ -2127,7 +2127,7 @@ fi
> # pixman support probe
> 
> if test "$pixman" = ""; then
> -  if $pkg_config --atleast-version=0.18.4 pixman-1 > /dev/null 2>&1; then
> +  if $pkg_config --atleast-version=0.16.4 pixman-1 > /dev/null 2>&1; then
>     pixman="system"
>   else
>     pixman="internal"
> @@ -2138,7 +2138,7 @@ if test "$pixman" = "system"; then
>   pixman_libs=`$pkg_config --libs pixman-1 2>/dev/null`
> else
>   if test ! -d ${source_path}/pixman/pixman; then
> -    echo "ERROR: pixman not present (or older than 0.18.4). Your options:"
> +    echo "ERROR: pixman not present (or older than 0.16.4). Your options:"
>     echo "  (1) Prefered: Install the pixman devel package (any recent"
>     echo "      distro should have packages as Xorg needs pixman too)."
>     echo "  (2) Fetch the pixman submodule, using:"
> -- 
> 1.7.1
> 
>