Re: [Qemu-devel] [PATCH 2/3 v4] vnc: added initial websocket protocol support

[Stefan Hajnoczi]

On Wed, Dec 12, 2012 at 11:04:16AM +0100, Tim Hardeck wrote:
> On 12/11/2012 11:04 AM, Stefan Hajnoczi wrote:
> > On Fri, Dec 07, 2012 at 03:56:34PM +0100, Tim Hardeck wrote:
> > 
> > Thanks for addressing my review comments.
> > 
> >> @@ -1328,13 +1358,14 @@ void vnc_client_read(void *opaque)
> >>  
> >>  void vnc_write(VncState *vs, const void *data, size_t len)
> >>  {
> >> -    buffer_reserve(&vs->output, len);
> >> +        buffer_reserve(&vs->output, len);
> >>  
> >> -    if (vs->csock != -1 && buffer_empty(&vs->output)) {
> >> -        qemu_set_fd_handler2(vs->csock, NULL, vnc_client_read, 
> >> vnc_client_write, vs);
> >> -    }
> >> +        if (vs->csock != -1 && buffer_empty(&vs->output)) {
> >> +            qemu_set_fd_handler2(vs->csock, NULL, vnc_client_read,
> >> +                    vnc_client_write, vs);
> >> +        }
> >>  
> >> -    buffer_append(&vs->output, data, len);
> >> +        buffer_append(&vs->output, data, len);
> > 
> > QEMU uses 4 spaces for indentation.
> I don't know how I missed that, probably during the removal of the
> previous parts, but `scripts/checkpatch.pl` didn't complain either.
> 
> Is the rest of the patchset fine?

A VNC expert needs to review it.  I only looked at coding style, logic
bugs, etc but didn't review VNC server or WebSocket protocol specifics.

Corentin or Anthony?

Reviewed-by: Stefan Hajnoczi <address@hidden>