qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V7 09/10] Use QemuOpts support in block layer


From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH V7 09/10] Use QemuOpts support in block layer
Date: Tue, 11 Dec 2012 16:52:47 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0

Am 06.12.2012 07:47, schrieb Dong Xu Wang:
> This patch will use QemuOpts related functions in block layer, add
> a member bdrv_create_options to BlockDriver struct, it will return
> a QemuOptsList pointer, which includes the image format's create
> options.
> 
> And create options's primary consumer is block creating related functions,
> so modify them together.
> 
> This patch also define a macro called STRINGIZER, it is used to convert
> number to string.
> 
> v6->v7:
> 1) use osdep.h:stringify(), not redefining new macro.
> 2) preserve TODO comment.
> 3) fix typo: BLOCK_OPT_ENCRYPT->BLOCK_OPT_STATIC.
> 4) initialize disk_type even when opts is NULL.
> 
> v5->v6:
> 1) judge if opts == NULL in block layer create functions.
> 2) use bdrv_create_file(filename, NULL) in qcow_create and cow_create funtion.
> 3) made more readable while using qemu_opt_get_number.
> 
> Signed-off-by: Dong Xu Wang <address@hidden>

This doesn't apply any more and needs a rebase.

Kevin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]