Re: [Qemu-devel] [Qemu-ppc] [PATCH 10/19] openpic: remove unused type variable

[Alexander Graf]

On 11.12.2012, at 00:42, Scott Wood <address@hidden> wrote:

> On 12/08/2012 07:44:33 AM, Alexander Graf wrote:
>> The openpic source irqs are carrying around a type indicator that
>> is never accessed by anything. Remove it.
>> Signed-off-by: Alexander Graf <address@hidden>
>> ---
>> hw/openpic.c |   27 ++-------------------------
>> 1 files changed, 2 insertions(+), 25 deletions(-)
>> diff --git a/hw/openpic.c b/hw/openpic.c
>> index e4ef23d..d252b2b 100644
>> --- a/hw/openpic.c
>> +++ b/hw/openpic.c
>> @@ -167,13 +167,6 @@ static uint32_t openpic_cpu_read_internal(void *opaque, 
>> hwaddr addr,
>> static void openpic_cpu_write_internal(void *opaque, hwaddr addr,
>>                                        uint32_t val, int idx);
>> -enum {
>> -    IRQ_EXTERNAL = 0x01,
>> -    IRQ_INTERNAL = 0x02,
>> -    IRQ_TIMER    = 0x04,
>> -    IRQ_SPECIAL  = 0x08,
>> -};
> 
> We may want to distinguish based on something like this in the future -- for 
> example, internal interrupts on FSL MPIC don't have a "sense" bit.

I would rather like to give irq lines flags than types then. An FSL MPIC could 
set a 'has no sense bit' flag in the irq line which means the sense bit is 
always masked out when written to.


Alex