Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function

[Andreas Färber]

Am 06.12.2012 10:48, schrieb Peter Maydell:
> On 6 December 2012 09:36, Andreas Färber <address@hidden> wrote:
>> The code comment specifically says "reset local breakpoints". IIUC you
>> are also resetting global breakpoints, which you shouldn't.
>>
>> Personally I'd be fine with a hw_local_breakpoint_enabled().
> 
> The check you want is
>  (hw_local_breakpoint_enabled() && !hw_global_breakpoint_enabled())
> 
> if you're going to do it like that. [We don't want to take out the
> bp if it was enabled globally as well as locally.]

If it doesn't exist already (I'm assuming not, otherwise it could've
been used) we could simply define the "local" function to return false
if global is enabled. :) But maybe that's too clever.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg