Re: [Qemu-devel] [PATCH v6 2/2] qemu-ga: sample fsfreeze hooks

[Luiz Capitulino]

On Wed, 05 Dec 2012 17:41:08 +0900
Tomoki Sekiyama <address@hidden> wrote:

> On 2012/12/05 1:51, Luiz Capitulino wrote:
> > On Fri, 30 Nov 2012 22:33:57 +0900
> > Tomoki Sekiyama <address@hidden> wrote:
> > 
> >> Adds sample hook scripts for --fsfreeze-hook option of qemu-ga.
> >>   - fsfreeze-hook : execute scripts in fsfreeze-hook.d/
> >>   - fsfreeze-hook.d.sample/mysql-flush.sh : quiesce MySQL before snapshot
> >>
> >> Signed-off-by: Tomoki Sekiyama <address@hidden>
> >> ---
> >>  docs/qemu-guest-agent/fsfreeze-hook                |   33 ++++++++++++
> >>  .../fsfreeze-hook.d.sample/mysql-flush.sh          |   55 
> >> ++++++++++++++++++++
> >>  2 files changed, 88 insertions(+)
> >>  create mode 100755 docs/qemu-guest-agent/fsfreeze-hook
> >>  create mode 100755 
> >> docs/qemu-guest-agent/fsfreeze-hook.d.sample/mysql-flush.sh
> >>
> >> diff --git a/docs/qemu-guest-agent/fsfreeze-hook 
> >> b/docs/qemu-guest-agent/fsfreeze-hook
> >> new file mode 100755
> >> index 0000000..ed7d86d
> >> --- /dev/null
> >> +++ b/docs/qemu-guest-agent/fsfreeze-hook
> >> @@ -0,0 +1,33 @@
> >> +#!/bin/sh
> >> +
> >> +# This script is executed when a guest agent receives fsfreeze-freeze and
> >> +# fsfreeze-thaw command, if it is specified in --fsfreeze-hook (-F)
> >> +# option of qemu-ga or placed in default path (/etc/qemu/fsfreeze-hook).
> >> +# When the agent receives fsfreeze-freeze request, this script is issued 
> >> with
> >> +# "freeze" argument before the filesystem is freezed. And for 
> >> fsfreeze-thaw
> >> +# request, it is issued with "thaw" argument after filesystem is thawed.
> >> +
> >> +LOGFILE=/var/log/qga-fsfreeze-hook.log
> >> +FSFREEZE_D=$(dirname -- "$0")/fsfreeze-hook.d
> > 
> > The script you introduce is called fsfreeze-hook.d.sample. If it's expected
> > that people really use these two scripts (vs. doc purposes only) I suggest
> > the following:
> > 
> >  1. Move these files to scripts/
> >  2. Drop the .sample suffix
> 
> It is good for "fsfreeze-hook". But as for "mysql-flush.sh", users may
> need to configure authentication etc. if their environments are with
> non-default setup (by edditing either the script or ~/.my.cnf file).
> 
> So, I'd like to (1)move these files to scripts/, but (2)reamin .sample
> suffix to indicate that users may need to modify the script.
> How do you think?

You could add the '.sample' suffix to the mysql script and add that
suffix to is_ignored_file().