[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-timer: Don't use RDTSC on 3
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-timer: Don't use RDTSC on 386s and 486s |
Date: |
Mon, 3 Dec 2012 14:00:30 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Nov 23, 2012 at 03:12:50PM +0000, Peter Maydell wrote:
> Adjust the conditional which guards the implementation of
> cpu_get_real_ticks() via RDTSC, so that we don't try to use it
> on x86 CPUs which don't implement RDTSC. Instead we will fall
> back to the no-cycle-counter-available default implementation.
>
> Reported-by: Yurij Popov <address@hidden>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> qemu-timer.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-timer.h b/qemu-timer.h
> index da7e97c..e35f163 100644
> --- a/qemu-timer.h
> +++ b/qemu-timer.h
> @@ -169,7 +169,7 @@ static inline int64_t cpu_get_real_ticks(void)
> return retval;
> }
>
> -#elif defined(__i386__)
> +#elif defined(__i586__)
>
> static inline int64_t cpu_get_real_ticks(void)
> {
> --
> 1.7.9.5
Dropping this due to the issue with gcc __i586__ that has been
discussed.
Stefan
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-timer: Don't use RDTSC on 386s and 486s,
Stefan Hajnoczi <=