qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/3] hw/arm_gic: Fix comparison with priority ma


From: Igor Mitsyanko
Subject: Re: [Qemu-devel] [PATCH 2/3] hw/arm_gic: Fix comparison with priority mask register
Date: Sun, 02 Dec 2012 01:27:39 +0400
User-agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1

On 11/29/2012 9:02 PM, Peter Maydell wrote:
The GIC spec states that only interrupts with higher priority
than the value in the GICC_PMR priority mask register are
passed through to the processor. We were incorrectly allowing
through interrupts with a priority equal to the specified
value: correct the comparison operation to match the spec.

Signed-off-by: Peter Maydell <address@hidden>
---
  hw/arm_gic.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/arm_gic.c b/hw/arm_gic.c
index f9e423f..672d539 100644
--- a/hw/arm_gic.c
+++ b/hw/arm_gic.c
@@ -73,7 +73,7 @@ void gic_update(GICState *s)
              }
          }
          level = 0;
-        if (best_prio <= s->priority_mask[cpu]) {
+        if (best_prio < s->priority_mask[cpu]) {
              s->current_pending[cpu] = best_irq;
              if (best_prio < s->running_priority[cpu]) {
                  DPRINTF("Raised pending IRQ %d\n", best_irq);



Reviewed-by: Igor Mitsyanko <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]