[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC 04/10] qdev: qdev_create(): use error_report() instead
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [RFC 04/10] qdev: qdev_create(): use error_report() instead of hw_error() |
Date: |
Fri, 30 Nov 2012 17:27:16 -0200 |
hw_error() is specific for fatal hardware emulation errors, not for
internal errors related to the qdev object/class abstraction or object
initialization.
Replace it with an error_report() call, followed by abort().
This will also help reduce dependencies of the qdev code (as hw_error()
is from cpus.o, and depends on the CPU list from exec.o).
Signed-off-by: Eduardo Habkost <address@hidden>
---
hw/qdev.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/hw/qdev.c b/hw/qdev.c
index 788b4da..599382c 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -109,10 +109,12 @@ DeviceState *qdev_create(BusState *bus, const char *name)
dev = qdev_try_create(bus, name);
if (!dev) {
if (bus) {
- hw_error("Unknown device '%s' for bus '%s'\n", name,
- object_get_typename(OBJECT(bus)));
+ error_report("Unknown device '%s' for bus '%s'\n", name,
+ object_get_typename(OBJECT(bus)));
+ abort();
} else {
- hw_error("Unknown device '%s' for default sysbus\n", name);
+ error_report("Unknown device '%s' for default sysbus\n", name);
+ abort();
}
}
--
1.7.11.7
- [Qemu-devel] [RFC 00/10] CPU DeviceState v8, Eduardo Habkost, 2012/11/30
- [Qemu-devel] [RFC 03/10] move -I$(SRC_PATH)/include compiler flag to Makefile.objs, Eduardo Habkost, 2012/11/30
- [Qemu-devel] [RFC 10/10] qom: make CPU a child of DeviceState, Eduardo Habkost, 2012/11/30
- [Qemu-devel] [RFC 09/10] include qdev code into *-user, too, Eduardo Habkost, 2012/11/30
- [Qemu-devel] [RFC 06/10] qdev: add stubs for vmstate register/unregister functions, Eduardo Habkost, 2012/11/30
- [Qemu-devel] [RFC 07/10] qdev: add sysbus_get_default() stub, Eduardo Habkost, 2012/11/30
- [Qemu-devel] [RFC 01/10] create qemu-types.h for struct typedefs, Eduardo Habkost, 2012/11/30
- [Qemu-devel] [RFC 02/10] sysemu.h: include qemu-types.h instead of qemu-common.h, Eduardo Habkost, 2012/11/30
- [Qemu-devel] [RFC 08/10] qdev-properties.c: separate core from the code used only by qemu-system-*, Eduardo Habkost, 2012/11/30
- [Qemu-devel] [RFC 04/10] qdev: qdev_create(): use error_report() instead of hw_error(),
Eduardo Habkost <=
- [Qemu-devel] [RFC 05/10] qdev: move reset handler list from vl.c to hw/reset.c, Eduardo Habkost, 2012/11/30