Re: [Qemu-devel] [PATCH 00/10] qemu-ga: revamp error messages (for 1.4)

[mdroth]

On Tue, Nov 27, 2012 at 11:01:54AM -0200, Luiz Capitulino wrote:
> This series revamps qemu-ga error messages by:
> 
>  - Propagating errors down to functions that generate errors
>  - Fixing UndefinedErrors
>  - Getting rid of sprint() + error_set()
>  - Other small fixes

Hi Luiz,

Patches look good other than a few comments on usage of possibly-unset errno.

CC'ing Eric as a heads up, but based on previous comments (libvirt
always using 'desc' field over 'class' field and reporting it directly
to users) I don't think it should cause any compatibility issues on that
end.

> 
> Only the POSIX port is covered in this series, win32 is left to another day.
> 
> Luiz Capitulino (10):
>   qemu-ga: guest_file_handle_find(): take an Error argument
>   qemu-ga: qmp_guest_file_close(): fix fclose() error check
>   qemu-ga: qmp_guest_file_*: improve error reporting
>   qemu-ga: qmp_guest_shutdown(): improve error reporting
>   qemu-ga: build_fs_mount_list(): take an Error argument
>   qemu-ga: qmp_guest_fsfreeze_*(): get rid of sprintf() + error_set()
>   qemu-ga: qmp_guest_fstrim(): get rid of sprintf() + error_set()
>   qemu-ga: qmp_guest_network_get_interfaces(): get rid of snprintf() +
>     error_set()
>   qemu-ga: bios_supports_mode(): improve error reporting
>   qemu-ga: guest_suspend(): improve error reporting
> 
>  qga/commands-posix.c | 244 
> ++++++++++++++++++++++++++++-----------------------
>  1 file changed, 134 insertions(+), 110 deletions(-)
> 
> -- 
> 1.8.0
>