qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] fbdev: fix pixman compile on old pixman


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH] fbdev: fix pixman compile on old pixman
Date: Mon, 26 Nov 2012 21:04:53 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.11) Gecko/20121116 Thunderbird/10.0.11

  Hi,

> Guard the PIXMAN_TYPE_BGRA branch like in the case right above the failing
> case, so that compilation is fixed. Functionality on such old pixman is a
> different question ;-).

> +#if PIXMAN_VERSION >= PIXMAN_VERSION_ENCODE(0, 21, 8)
>              type = PIXMAN_TYPE_BGRA;
> +#endif

Version is wrong, on 0.18.4 this builds just fine, so PIXMAN_TYPE_BGRA
must be older than that.

I'd also tend to just change the check in configure instead and ignore
system pixman in case it is too old.

cheers,
  Gerd



reply via email to

[Prev in Thread] Current Thread [Next in Thread]