Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges

[Alexander Graf]

On 23.11.2012, at 14:44, Michael S. Tsirkin wrote:

> On Fri, Nov 23, 2012 at 11:59:51PM +1100, David Gibson wrote:
>>> Look, even if solution using a required property is less elegant for CLI
>>> use, it will work, won't it?
>>> So how about we merge it so that things work, and then we can discuss a
>>> patch on top that auto-generates this property?
>> 
>> Well, there you have a point.  And actually I've realised there are
>> other things we need to assign uniquely for each PHB and don't yet (IO
>> window addresses).  So I need to look at a wider rework of this, which
>> I'll start on next week.
> 
> Fine. Basically my point is it's typically a mistake to
> make some userspace visible parameter depend on order
> of initialization of devices in qemu. I don't insist
> on making users fully specify such parameters but it
> is one way to do this.

I think it's reasonable to require to be able to specify it. If you don't, it's 
fine to base on device order IMHO. But you have to have the ability to specify 
it by hand if your management tool of choice actually wants reproducible 
results.


Alex