[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [kvmarm] [RFC v4 8/8] oslib-posix: Align to permit tran
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [kvmarm] [RFC v4 8/8] oslib-posix: Align to permit transparent hugepages on ARM Linux |
Date: |
Tue, 20 Nov 2012 14:48:24 +0000 |
On 20 November 2012 14:37, Alexander Graf <address@hidden> wrote:
> On 11/20/2012 02:55 PM, Christoffer Dall wrote:
>> On Tue, Nov 20, 2012 at 8:54 AM, Alexander Graf<address@hidden> wrote:
>>> On 11/20/2012 02:31 PM, Peter Maydell wrote:
>>>> ARM Linux (like x86-64 Linux) can use transparent hugepages for
>>>> KVM if memory blocks are 2MiB aligned; set QEMU_VMALLOC_ALIGN
>>>> accordingly.
>>>> -#if defined(__linux__)&& defined(__x86_64__)
>>>> +#if defined(__linux__)&& (defined(__x86_64__) || defined(__arm__))
>>>
>>>
>>> Why not just drop the arch specific bit?
>> other archs have other alignment requirements, iirc.
>
> Ah, sorry, missed the rest of the lines around this one :).
> Yeah, should be ok then.
Yeah. Ideally the kernel would provide a mechanism so we can
ask at runtime what the preferred alignment is. (Or it could
just automatically provide it for suitably large allocations.)
In the absence of that this is just following along with the
current style.
-- PMM
[Qemu-devel] [RFC v4 6/8] hw/kvm/arm_gic: Implement support for KVM in-kernel ARM GIC, Peter Maydell, 2012/11/20
[Qemu-devel] [RFC v4 7/8] configure: Enable KVM on ARM, Peter Maydell, 2012/11/20
[Qemu-devel] [RFC v4 5/8] target-arm: Use MemoryListener to identify GIC base address for KVM, Peter Maydell, 2012/11/20
[Qemu-devel] [RFC v4 1/8] linux-headers: Add ARM KVM headers (not for upstream), Peter Maydell, 2012/11/20
[Qemu-devel] [RFC v4 3/8] ARM KVM: save and load VFP registers from kernel, Peter Maydell, 2012/11/20
[Qemu-devel] [RFC v4 2/8] ARM: KVM: Add support for KVM on ARM architecture, Peter Maydell, 2012/11/20