[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-ppc] [PATCH 08/12] target-ppc: Convert ppcemb_tlb
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [Qemu-ppc] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN |
Date: |
Tue, 20 Nov 2012 09:48:23 +1100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Nov 19, 2012 at 05:26:45PM +0100, Alexander Graf wrote:
>
> On 13.11.2012, at 03:46, David Gibson wrote:
>
> > Currently the ppcemb_tlb_t struct, used on a number of embedded ppc models
> > to represent a TLB entry contains a hwaddr. That works reasonably for now,
> > but is troublesome for saving the state, which we'll want to do in future.
> > hwaddr is a large enough type to contain a physical address for any
> > supported machine - and can thus, in theory at least, vary depending on
> > what machines are enabled other than the one we're actually using right
> > now (though in fact it doesn't for ppc). This makes it unsuitable for
> > describing in vmstate.
> >
> > This patch therefore changes ppcemb_tlb_t to use a fixed 64-bit integer
> > which we know is sufficient for all the machines which use this structure.
>
> hwaddr is always defined to 64bit by now.
I know, but there aren't state save helpers for hwaddr, and there are
objections to creating them.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
- [Qemu-devel] [PATCH 03/12] pseries: Move XICS initialization before cpu initialization, (continued)
[Qemu-devel] [PATCH 05/12] pseries: Allow RTAS tokens without a qemu handler, David Gibson, 2012/11/12
[Qemu-devel] [PATCH 09/12] pseries: Implement PAPR NVRAM, David Gibson, 2012/11/12
[Qemu-devel] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN, David Gibson, 2012/11/12
- Re: [Qemu-devel] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN, Alexander Graf, 2012/11/19
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN,
David Gibson <=
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN, Alexander Graf, 2012/11/20
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN, Peter Maydell, 2012/11/20
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN, Alexander Graf, 2012/11/20
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN, David Gibson, 2012/11/20
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN, Alexander Graf, 2012/11/20
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN, David Gibson, 2012/11/20
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN, Alexander Graf, 2012/11/21
[Qemu-devel] [PATCH 06/12] pseries: Add tracepoints to the XICS interrupt controller, David Gibson, 2012/11/12
[Qemu-devel] [PATCH 07/12] pseries: Split xics irq configuration from state information, David Gibson, 2012/11/12
[Qemu-devel] [PATCH 11/12] pseries: Fix bug in PCI MSI allocation, David Gibson, 2012/11/12